This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf($parse): improve performance of assignment expressions #14957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a ~5% improvement in the `parsed-expressions-bp/assignment` benchmark (which only contains assignment expressions). In real-world applications, the time spent in assignment expressions will be a tiny fragment of the overall processing time.
|
Btw, this essentially voids the prototype check if any of the banned prototypes changes dynamically (i.e. after we have cached it). Considering these checks are not security-related and that dynamically changing prototypes of core constructors is likely to break other things as well, I don't think it should be a concern. /fyi @petebacondarwin |
|
I note that we were already caching |
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Aug 8, 2016
There was a ~5% improvement in the added `parsed-expressions-bp/assignment` benchmark (which only contains assignment expressions). In real-world applications, the time spent in assignment expressions will be a tiny fragment of the overall processing time, though. Closes #14957
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Minor perf improvement.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
There was a ~5% improvement in the
parsed-expressions-bp/assignmentbenchmark (which only contains assignment expressions). In real-world applications, the time spent in assignment expressions will be a tiny fragment of the overall processing time (so this change is hardly expected to make any noticeable difference).Related to #14951.