This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Pr 14893 #14910
Closed
Pr 14893 #14910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
force-pushed
the
pr-14893
branch
from
f6b7a42 to
003ac6a
Compare
|
This actually creates more potential problems than it solves and #14893 is simpler. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
ng-viewdirectives inside async loaded templates do not display the correct view if the location change occurred before $route was instantiated.What is the new behavior (if this is a feature change)?
Now we track all location changes before $route is instantiated, which are then used to initialize the current route.
Does this PR introduce a breaking change?
No (I don't think)
Please check if the PR fulfills these requirements
Other information: