test(jQuery): Run tests with jQuery 3 #14874
Conversation
| expect(element.val()).toBe(null); | ||
|
|
||
| // Cover both jQuery 3.x ([]) and 2.x (null) behavior. | ||
| var val = element.val(); |
There was a problem hiding this comment.
How about toEqual(null || [])? Does that work?
There was a problem hiding this comment.
toEqual(null || []) is the same as toEqual([]). :-) The expression will be computed before passing it to toEqual.
There was a problem hiding this comment.
We have custom toBeOneOf() matcher. If we only had toEqualOneOf() 😛
|
Most of the data in the jquery karma conf could be moved into a shared file. |
|
Looking at the travis logs, it seems that |
|
@gkalpak Could you be more specific? I don't see such a divergence anywhere. |
|
In the travis log of this PR's jqLite: 42736 tests (Different number of tests for In the travis log of the latest master build's jqLite: 41660 tests (Same number of tests for |
mgol
changed the title
|
@gkalpak These results are weird. I updated jQuery to 3.1.0 and rebased my PR and now the numbers don't diverge that much; in particular, jQuery 2.1 has the same number of tests run as jQuery 2.2). On the other hand, on one of the commits on master I see 42794 tests run on jQuery 2.2 but only 39294 on jQuery 2.1. It seems like some of the tests was being skipped by random (or the total sum is being calculated incorrectly). In any case, this doesn't seem related to changes in this PR. |
I hope it is the latter. It will be very worrying, if it is the former 😟 |
|
After comparing a couple of master builds, it turns out that the diviations are all related to Safari (for which the total number of tests are always reported as 0 as well). There is obviously some issue with Safari (or some Safari launcher/adapter) wrt to test counts. In any case, not related to this PR as you said. LGTM |
I extracted the shared parts. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A test update.
What is the current behavior? (You can also link to an open issue here)
Currently Angular is tested with jQuery 2.1 & 2.2. jQuery 2.2 is used for e2e tests.
What is the new behavior (if this is a feature change)?
Angular will be tested with jQuery 2.1, 2.2 & 3.0; the latest one will be used for e2e tests.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information: