This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(tutorial): fix typo in images (phoneList --> phoneDetail) #14868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you generate the svgs from an editor or did you edit them inline? (I just wonder where all the other changes come from) |
|
I use InkScape. No idea where the unrelated changes came from. I basically modified the text and shifted it a bit to the right. |
|
Then LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs fix.
What is the current behavior? (You can also link to an open issue here)
The images for steps 10 and 12 mention the wrong component (
phoneListinstead ofphoneDetail).See #14858.
What is the new behavior (if this is a feature change)?
The correct component is mentioned (
phoneDetail).Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Other information:
Fixes #14858