fix($resource): append extra params even if Object.prototype has properties with the same name

[gkalpak]

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
If Object.prototype has a property named xyz, then an extra xyz param passed to a $resource action call, does not get passed to $http (in config.params).
See #14866.

What is the new behavior (if this is a feature change)?
If Object.prototype has a property named xyz, then an extra xyz param passed to a $resource action call, does get passed to $http (in config.params).

Does this PR introduce a breaking change?
Possibly. If someone relied on using a params object with own, enumerable properties that have the same names with properties on Object.prototype and not have these properties passed to $http (and included in the URL as query params), then this would break them. Highly unlikely though.

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Other information:
Fixes #14866

[Narretz]

I think we usually did createMap() (which does Object.create(null)) in these cases. Could we apply this here too?

[gkalpak]

I think we usually did createMap() (which does Object.create(null)) in these cases

That was my initial intention, but then somehow I forgot 😕
Fixed!

[lgalfaso]

I would change the commit log to Add as params all owned properties and think it is best to squash this into a single commit. Otherwise LGTM

[gkalpak]

Should we just merge it in 1.6.x only and mark it as a BC. (I don't expect this to actually break any apps or tests, but it wouldn't be the first time something breaks unexpectedly 😃)

[Narretz]

Yes, let's merge just in 1.6 with a BC notice. It should be pretty easy to work around this in an affected app (not to mention that this happens rarely)

[gkalpak]

Landed on 1.6.x. Thx for the reviews 😄