Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Expressions): Redirection to MDN #14863

Merged
merged 1 commit into from
Jul 4, 2016

Conversation

franciscovelez
Copy link
Contributor

@franciscovelez franciscovelez commented Jul 4, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

It is better to link to the English version of MDN rather than German version

It is better to link to the English version of MDN rather than German version
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@franciscovelez
Copy link
Contributor Author

I signed it!

@franciscovelez franciscovelez changed the title docs: (guide/Expressions): Redirection to MDN docs(guide/Expressions): Redirection to MDN Jul 4, 2016
@Narretz
Copy link
Contributor

Narretz commented Jul 4, 2016

I agree. Or maybe simply leave out the local modifier? That works too

@franciscovelez
Copy link
Contributor Author

I think that is better use the local modifier to avoid the 301 redirection from "no local modifier" to "en-US" page

@Narretz
Copy link
Contributor

Narretz commented Jul 4, 2016

Ok, that makes sense. Regarding the CLA, did you sign it with the same email with which you authored the commit? Otherwise it won't detect it.

@franciscovelez
Copy link
Contributor Author

OK, I have signed the CLA with my other email

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 4, 2016
@Narretz Narretz merged commit 6a219ad into angular:master Jul 4, 2016
@franciscovelez franciscovelez deleted the patch-1 branch July 4, 2016 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants