-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(guide/Expressions): Redirection to MDN #14863
Conversation
It is better to link to the English version of MDN rather than German version
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
I agree. Or maybe simply leave out the local modifier? That works too |
I think that is better use the local modifier to avoid the 301 redirection from "no local modifier" to "en-US" page |
Ok, that makes sense. Regarding the CLA, did you sign it with the same email with which you authored the commit? Otherwise it won't detect it. |
OK, I have signed the CLA with my other email |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information:
It is better to link to the English version of MDN rather than German version