This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($resource): fulfill promise with the correct value on error #14839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test currently fail on master, but should pass on 1.5.x. A subsequent commit will fix the regressions on master. (This commit should be backportable to 1.5.x.) Related to angular#14837.
This fixes a regression introduced with 71cf28c. See angular#14837 for more info. Fixes angular#14837
| @@ -776,13 +778,18 @@ angular.module('ngResource', ['ng']). | |||
| (success || noop)(value, response.headers); | |||
| return value; | |||
| }, | |||
| responseErrorInterceptor || error ? | |||
| (hasError || hasResponseErrorInterceptor) ? | |||
There was a problem hiding this comment.
Can we use a real if here? The whole block is pretty hard to read (for me)
No, we can't, because it's the error fn of the promise
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
See #14837.
What is the new behavior (if this is a feature change)?
Restores the 1.5.x behavior.
Does this PR introduce a breaking change?
No, since it fixes (yet unreleased) regression.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #14837
The first commit (which only contains a couple of tests) could be backported to 1.5.x, in order to verify that the behavior is correct on that branch.