-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Update step_03.ngdoc with corrected grammar and usage #14834
Conversation
Some more usage and grammar edits.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed the CLA! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Thx for the fixes 👍 I kept the spaces around the em—dash, since I think it makes the text more readable, is consistent with the rest of the tutorial and is a matter of style/preference (from what I understand). |
Of course! I'm planning on working through the rest of the tutorial material, because Thanks, On Tue, Jun 28, 2016 at 3:47 AM, Georgios Kalpakas <[email protected]
sent from internet |
Awesome! A good tip for pull requests is to keep them small and focused. E.g. having one PR per step is better than having one giant PR for the whole tutorial (unless there are very few modifications per step). If you want to go the extra mile, there are some conventions we follow regarding our commit messages 😃 Thx and have fun learning Angular! |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs edits.
Purely grammar and usage edits.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information:
Some more usage and grammar edits.