Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update step_03.ngdoc with corrected grammar and usage #14834

Closed
wants to merge 1 commit into from
Closed

Update step_03.ngdoc with corrected grammar and usage #14834

wants to merge 1 commit into from

Conversation

atenhar
Copy link
Contributor

@atenhar atenhar commented Jun 27, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs edits.
Purely grammar and usage edits.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

Some more usage and grammar edits.

Some more usage and grammar edits.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@atenhar
Copy link
Contributor Author

atenhar commented Jun 27, 2016

I signed the CLA!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak gkalpak closed this in 3cda897 Jun 28, 2016
gkalpak pushed a commit that referenced this pull request Jun 28, 2016
@gkalpak
Copy link
Member

gkalpak commented Jun 28, 2016

Thx for the fixes 👍

I kept the spaces around the em—dash, since I think it makes the text more readable, is consistent with the rest of the tutorial and is a matter of style/preference (from what I understand).

@atenhar
Copy link
Contributor Author

atenhar commented Jun 28, 2016

Of course!

I'm planning on working through the rest of the tutorial material, because
I'm trying to learn Angular, and will want to make other grammatical and
usage edits. Can you let me know if there is anything I should change or
keep in mind when making edits and pull requests? I've never used github
before.

Thanks,
Andrew

On Tue, Jun 28, 2016 at 3:47 AM, Georgios Kalpakas <[email protected]

wrote:

Thx for the fixes 👍

I kept the spaces around the em—dash, since I think it makes the text more
readable, is consistent with the rest of the tutorial and is matter of
style (from what I understand).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14834 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ATPWtEDYHF0ypeYRPiDj94IZzu1_QAILks5qQN-_gaJpZM4I_jRh
.

sent from internet

@gkalpak
Copy link
Member

gkalpak commented Jun 28, 2016

Awesome!

A good tip for pull requests is to keep them small and focused. E.g. having one PR per step is better than having one giant PR for the whole tutorial (unless there are very few modifications per step).

If you want to go the extra mile, there are some conventions we follow regarding our commit messages 😃

Thx and have fun learning Angular!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants