Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($animate): do not get affected by custom, enumerable properties on Object.prototype #14830

Closed
wants to merge 1 commit into from
Closed

fix($animate): do not get affected by custom, enumerable properties on Object.prototype #14830

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jun 26, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Regression fix.

What is the current behavior? (You can also link to an open issue here)
Putting custom, enumerable properties on Object.prototype, can break animations.
See #14804.

What is the new behavior (if this is a feature change)?
Animations are not affected by custom, enumerable properties on Object.prototype.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

Other information:
Fixes #14804.

@gkalpak gkalpak added this to the 1.5.8 milestone Jun 26, 2016
@Narretz
Copy link
Contributor

Narretz commented Jun 27, 2016

LGTM

gkalpak added a commit that referenced this pull request Jun 27, 2016
@gkalpak
fix($animate): do not get affected by custom, enumerable properties o…
181e440 
…n `Object.prototype`

Fixes #14804

Closes #14830
@gkalpak gkalpak closed this in 6050f0b Jun 27, 2016
@gkalpak gkalpak deleted the refactor-animateQueue-callbackRegistry branch June 27, 2016 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Narretz Narretz

Labels
cla: yes component: ngAnimate frequency: low needs: review severity: regression type: bug
Projects
None yet
Milestone
1.5.8
Development

Successfully merging this pull request may close these issues.

'list.filter is not a function' in filterFromRegistry in animateQueue.js in 1.5.5+
3 participants
@gkalpak @Narretz @googlebot