Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Filters): adding a a clear link to angular built-in filters #14828

Closed
wants to merge 1 commit into from

Conversation

lirantal
Copy link
Contributor

@lirantal lirantal commented Jun 26, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Documentation update for the online guide of angularjs

What is the current behavior? (You can also link to an open issue here)
In the Filter guide on the angularjs docs, there are a few examples of filters but no direct link to see a list of the supported built-in filters

What is the new behavior (if this is a feature change)?
Making it clear to the reader where to find a list of supported built-in filters: https://docs.angularjs.org/api/ng/filter

Does this PR introduce a breaking change?
No, it's a documentation update.

Please check if the PR fulfills these requirements

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@lirantal
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak gkalpak closed this in 56a9eab Jun 26, 2016
@gkalpak
Copy link
Member

gkalpak commented Jun 26, 2016

Tweaked it a bit and landed. Thx!

gkalpak pushed a commit that referenced this pull request Jun 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants