Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

remove useless code in function jqLiteBuildFragment #14822

Conversation

deplay
Copy link
Contributor

@deplay deplay commented Jun 24, 2016

discussed at #14810

remove useless code in function jqLiteBuildFragment

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@deplay
Copy link
Contributor Author

deplay commented Jun 24, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented Jun 24, 2016

Can you please update the commit message according to our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format

@deplay
Copy link
Contributor Author

deplay commented Jun 24, 2016

@Narretz
is it ok?
or anything else is needed?
thank you

@Narretz
Copy link
Contributor

Narretz commented Jun 24, 2016

Not quite, sorry. In the commit message, you should write "refactor" instead of "fix".
And ofr the future, make sure that there are no merge commits on the branch (i.e. amend the commit instead)

@deplay
Copy link
Contributor Author

deplay commented Jun 24, 2016

@Narretz
I will delete this refactor branch after merge.

@gkalpak
Copy link
Member

gkalpak commented Jun 25, 2016

@deplay, as @Narretz said, it makes things easier for us (and hopefully you), if the change was on a single commit with the appropriate commit message.
Something to keep in mind for the next time 😃

@deplay
Copy link
Contributor Author

deplay commented Jun 26, 2016

@gkalpak Thank u for your suggestion.
also @Narretz ,thank you for your patient reply on this PR.
I will follow the rules in later contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants