Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngReadonly): added note about input type checkbox and radio #14816

Closed
wants to merge 2 commits into from

Conversation

vasekch
Copy link

@vasekch vasekch commented Jun 22, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

Current docs does not mention, that ngReadonly does work with input type checkbox|radio.

What is the new behavior (if this is a feature change)?

Added note to docs string.

Does this PR introduce a breaking change?

No, text change in comment only.

Please check if the PR fulfills these requirements

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vasekch
Copy link
Author

vasekch commented Jun 22, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented Jun 22, 2016

This doesn't only apply to checkbox and radio - see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-readonly

I'd would rather add a link to this section in the docs, so that we don't have to keep that up to date.

@Narretz Narretz added this to the Purgatory milestone Jun 22, 2016
@Narretz Narretz closed this in c434bde Jun 23, 2016
Narretz added a commit that referenced this pull request Jun 23, 2016
@vasekch
Copy link
Author

vasekch commented Jun 23, 2016

@Narretz Ok, agreed, thanks for processing through.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants