This repository was archived by the owner on Apr 12, 2024. It is now read-only.
allow json callback customisation #14795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e handled You can now override this service if you have specific requirements about the behaviour and formatting of the JSON_CALLBACK that is sent to the server for `$http.jsonp` requests.
| browserTrigger(script, "load"); | ||
|
|
||
| expect(callback).toHaveBeenCalledOnce(); | ||
| }); | ||
|
|
||
|
|
||
| it('should clean up the callback and remove the script', function() { | ||
| spyOn($jsonpCallbacks, 'wasCalled').and.callThrough(); |
|
A few minor comments - LGTM otherwise. |
Use the built-in service to handling callbacks to `$http.jsonp` requests. Closes angular#3073
petebacondarwin
force-pushed
the
issue-3073
branch
from
c7cf465 to
c1a335d
Compare
|
I fixed up IE... the problem was that occasionally, in the test, it was actually triggering the script callback at some point in the future, after the test had completed. When this happened the status of the response was a 404. So I put in a check that the status of the response is a 200 before trying to get hold of the response. |
…e handled You can now override this service if you have specific requirements about the behaviour and formatting of the JSON_CALLBACK that is sent to the server for `$http.jsonp` requests.
Use the built-in service to handling callbacks to `$http.jsonp` requests. Closes angular#3073
|
@gkalpak thanks for the review. PTAL |
| callbacks[callbackId] = noop; | ||
| var callbackPath = callbacks.createCallback(url); | ||
| var jsonpDone = jsonpReq(url, callbackPath, function(status, text) { | ||
| var response = (status === 200) && callbacks.getResponse(callbackPath); |
There was a problem hiding this comment.
Minor: I would add a note that status is set in jsonpReq() and it can be either -1, 404 or 200.
The first time I saw this, I thought: "What if it is in the (200, 300) range?"
|
LGTM 👍 |
|
Thanks. I'll comment on the |
petebacondarwin
added a commit
that referenced
this pull request
Jun 21, 2016
…e handled You can now override this service if you have specific requirements about the behaviour and formatting of the JSON_CALLBACK that is sent to the server for `$http.jsonp` requests. Closes #14795
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat
What is the current behavior? (You can also link to an open issue here)
hard-coded jsonp callback handling
What is the new behavior (if this is a feature change)?
overridable
$jsonpCallbacksservice that offers a place where customisation can be appliedDoes this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
See the commits