Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(misc/downloading): update content - include missing modules #14746

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jun 9, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:
I deliberately didn't mention the ngMessageFormat module, since it seems to not be developed/maintained any more. Do we still want to mention it ?

apps even easier. Your unit/integration test harness should load this file after `angular.js` is
loaded.

* __`angular-loader.js`__ — Module loader for Angular modules. If you are loading multiple
Copy link
Contributor

@Narretz Narretz Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you need to load the loader and then angular.js before any other module files, as many of them rely on angular.* helpers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as it was previously (probably outdated as the rest of the content 😃).

TBH, I've never used the loader. So, does it mean you need to load the loader (synchronously), then angular.js (synchronously), then other modules (asynchronously and in any order) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so. See #9140 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I'll add a note, but angular-seed needs fixing too.
(Although I think its index-async is already broken for soe reason. It's been sitting on my todo list for a while to take a deeper look - I guess it's time 😃)

@Narretz
Copy link
Contributor

Narretz commented Jun 9, 2016

I don't see why we can't "advertise" ngMessageFormat. It works even though it's not complete.

@gkalpak gkalpak deleted the docs-downloading-update-content branch June 10, 2016 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants