This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(tutorial): add deprecation notice to v1.4.x tutorial and point to the correct branch #14675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the correct branch - Add a deprecation notice on the 'index' page. - Hide the "Live Demo" buttons (since we don't have a live demo). - Update the GitHub diff links to point to the `pre-v1.5.0-snapshot` angular-phonecat branch. - Modify all git commangs to use the appropriate branch and tags. Related to angular#14416.
|
The only thing missing (except for merging this PR) is to create the (We might need better names for |
|
@petebacondarwin, I have assigned you, since you are the official tutorial reviewer this month 😛 |
| scope.diffLo = seq ? (seq - 1): '0~1'; | ||
| scope.diffHi = seq; | ||
| scope.diffLo = 13 - seq; | ||
| scope.diffHi = 12 - seq; |
There was a problem hiding this comment.
why these changes?
There was a problem hiding this comment.
Hm...I made them before I created the new tags. Now that we have the tags, I should just change compare/step- to compare/old-step- 😃
gkalpak
force-pushed
the
v1.4.x-docs-tutorial-add-point-to-old-version
branch
from
89d88e9 to
9d06681
Compare
|
@petebacondarwin, I made the changes. PTAL |
|
Renamed branch to |
gkalpak
added a commit
that referenced
this pull request
May 31, 2016
…o the correct branch - Add a deprecation notice on the 'index' page. - Hide the "Live Demo" buttons (since we don't have a live demo). - Update the GitHub diff links to point to the `1.4-snapshot` angular-phonecat branch. - Modify all git commangs to use the appropriate branch and tags (e.g. `1.4-step-*`). Related to #14416. Closes #14675
|
Closed via 6234cda. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Other information:
pre-v1.5.0-snapshot1.4-snapshotangular-phonecat branch.Related to #14416.