Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($location): describe your change... #14544

Merged
merged 1 commit into from
May 6, 2016
Merged

docs($location): describe your change... #14544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/location.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ var locationPrototype = {
* ```
*
* @param {(string|number)=} path New path
* @return {string} path
* @return {(string|object)} path if called with no parameters, or `$location` if called with a parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think objects are supported per se, they just work because we call toString on path, which was added here: #7054. I think we shouldn't have built in handling for intergers, as the docs clearly say the path must be a string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard my last comment, I was in the wrong line.

*/
path: locationGetterSetter('$$path', function(path) {
path = path !== null ? path.toString() : '';
Expand Down