This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($sanitizeProvider): fix param comment for enableSvg #14543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the text of the doc comment for the parameter of enableSvg to match the type of the comment and the behavior of the code.
Narretz
pushed a commit
that referenced
this pull request
May 6, 2016
Change the text of the doc comment for the parameter of enableSvg to match the type of the comment and the behavior of the code (#14543).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
The param is listed as type boolean, but has an erroneous comment describing it as a regex. (Maybe from a much earlier version of Angular?)
What is the new behavior (if this is a feature change)?
No behavior change. Fixes the doc comment.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
I submitted a pull request for this previously, but the commit had the wrong email address so it didn't catch my CLA, so I'm resubmitting now.