perf($animate): listen for document visibility changes #14519
Conversation
perf(ngAnimate): listen for document visibility changes Accessing the document for the hidden state is costly for platforms like Electron. Instead, listen for visibilitychange and store the state. (angular#14071) Closes angular#14066
| }); | ||
|
|
||
| function changeListener() { | ||
| hidden = doc.hidden; |
There was a problem hiding this comment.
You are checking if doc is available in line 42 but not here. Is this correct? Is the check above necessary?
There was a problem hiding this comment.
I think the check was originally introduced by @matsko in case the document isn't available. I assume that when the document isn't available I can't add a listener anyway.
|
On Apr 27, 2016 2:41 AM, "Martin Staffa" [email protected] wrote:
|
|
Superseded by #14568. Turns out you can't squash the PR when your try to merge from the same branch in your fork. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information:
perf(ngAnimate): listen for document visibility changes
Accessing the document for the hidden state is costly for
platforms like Electron. Instead, listen for visibilitychange
and store the state.
(#14071)
Closes #14066