This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): still trigger $onChanges even if the inner value alr…
#14406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eady matches the new value
| @@ -3233,7 +3237,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { | |||
| onChangesQueue.push(triggerOnChangesHook); | |||
| } | |||
| // If the has been a change on this property already then we need to reuse the previous value | |||
| if (changes[key]) { | |||
| if (isDefined(changes[key])) { | |||
There was a problem hiding this comment.
It seemed safer
There was a problem hiding this comment.
But I guess since the property value must be undefined or an object it is not strictly necessary
There was a problem hiding this comment.
Feel free to do a refactor commit to remove it :-)
…eady matches the new value
petebacondarwin
added a commit
that referenced
this pull request
Apr 10, 2016
…eady matches the new value Closes #14406
petebacondarwin
added a commit
that referenced
this pull request
Apr 10, 2016
…eady matches the new value Closes #14406
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
the
$onChangeshook is not getting called if the value on the controller is already set to the new valueA2 does trigger this value - see http://plnkr.co/edit/V15jwFA7e5zsWgLVLDKf?p=preview
What is the new behavior (if this is a feature change)?
now the hook is triggered
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information:
…eady matches the new value