Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(package.json): remove unused grunt-jasmine-node #14363

Closed
wants to merge 1 commit into from

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Apr 2, 2016

At least, it looks unused.

@lgalfaso
Copy link
Contributor

lgalfaso commented Apr 3, 2016

npm run test-i18n ?

@thorn0
Copy link
Contributor Author

thorn0 commented Apr 3, 2016

Does it use grunt?

@gkalpak
Copy link
Member

gkalpak commented Apr 3, 2016

npm run test-i18n is using jasmine-node directly (package.json#L20-L21).

@Narretz
Copy link
Contributor

Narretz commented Apr 7, 2016

If Travis passes, does that mean we can safely remove it?

@Narretz Narretz added this to the Backlog milestone Apr 7, 2016
@Narretz
Copy link
Contributor

Narretz commented May 25, 2016

Do we need to update the shrinkwrap for this, too?

@gkalpak
Copy link
Member

gkalpak commented May 25, 2016

I think we do.

@thorn0
Copy link
Contributor Author

thorn0 commented May 25, 2016

done

@gkalpak gkalpak closed this in 5e7c4ab May 25, 2016
gkalpak pushed a commit that referenced this pull request May 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants