This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): ensure that $onChanges hook is called correctly
#14355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgol does this fix your problem too? |
|
I'll have a look tomorrow.
|
| @@ -3735,7 +3743,10 @@ describe('$compile', function() { | |||
| $rootScope.$watch('a', function(val) { $rootScope.b = val * 2; }); | |||
|
|
|||
| // There should be no changes initially | |||
|
After removing the one outdated comment, LGTM. 👍 |
Due to the way that we instantiate controllers, the `$onChanges` hook was not always available at the time we were trying to trigger the initial call to this hook. For instance, if the hook was actually defined inside the constructor function. This commit fixes that but also fixes the fact that the initial call was being made in the postDigest anyway, which was incorrect because the it should have been made before the `$onInit` call.
petebacondarwin
force-pushed
the
init-onchanges
branch
from
92d022d to
4784a93
Compare
petebacondarwin
added a commit
that referenced
this pull request
Apr 1, 2016
Due to the way that we instantiate controllers, the `$onChanges` hook was not always available at the time we were trying to trigger the initial call to this hook. For instance, if the hook was actually defined inside the constructor function. This commit fixes that but also fixes the fact that the initial call was being made in the postDigest anyway, which was incorrect because the it should have been made before the `$onInit` call. Closes #14355 Closes #14359
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
the
$onChangeshook is not being called correctlyPlease check if the PR fulfills these requirements
[ ] Docs have been added / updated (for bug fixes / features)Other information:
Due to the way that we instantiate controllers, the
$onChangeshookwas not always available at the time we were trying to trigger the initial
call to this hook. For instance, if the hook was actually defined inside
the constructor function.
This commit fixes that but also fixes the fact that the initial call was
being made in the postDigest anyway, which was incorrect because the
it should have been made before the
$onInitcall.