This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix animation event regression #14340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Narretz
force-pushed
the
fix-animation-event-regression
branch
from
fe61088 to
d9ba9bb
Compare
…been called The fix for removing the event callbacks on destroy introduced in ce7f400 removed the events too early, so that the event callbacks for the "close" phase in "leave" animations were not called. This commit fixes the behavior so that the event callbacks are only removed during on('$destroy') when no animation is currently active on the element. When an animation is active, the event callbacks will be removed after all callbacks have run, and if the element has no parent (has been removed from the DOM). Closes angular#14321
Narretz
force-pushed
the
fix-animation-event-regression
branch
from
d9ba9bb to
f8e6a4b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
regression fix for #14321
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
@matsko Do you think you could take a look at this?