This repository was archived by the owner on Apr 12, 2024. It is now read-only.
tests(jQuery): test on both oldest & latest supported jQuery version (+ a minor jqLite refactor) #14229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I created 3 commits as they made sense as encapsulated changes. |
|
A couple of minor comments but otherwise looks good. |
mgol
changed the title
The useCapture parameter defaults to false even in oldest of our supported browsers; this is no longer needed. jQuery has removed it in 2.2 as well.
Code patching the change event in jQuery doesn't exist in jQuery 2 so this patch hasn't been needed since Angular 1.3
|
The PR is ready but Travis can't connect to Sauce Labs: Do we have too many projects using the same Sauce key? |
|
Landed! Thanks @mgol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor.
What is the current behavior? (You can also link to an open issue here)
useCaptureparameter is passed toadd/removeEventListener, there are wrappers created for those methods.What is the new behavior (if this is a feature change)?
useCaptureparameter).Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
None.