Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Component router guide #14131

Merged

Conversation

petebacondarwin
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

docs update!

  • Other information:

So this is still a draft but it could be good enough to merge and iterate on.
The big problem is that, at the moment, I had to include the whole of the router code in the runnable example.

You can see a demo of the guide here: https://ci.angularjs.org/job/angular.js-pete/1073/artifact/build/docs/guide/component-router

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Feb 26, 2016

Looks good overall (there are a few typis here and there, but the diff is not displayed to comment 😞)

It might be better to remove the Crisis Center bits from the example, since it's not mentioned in the guide. (Maybe provide the whole app (with Crisis Center) at the end as a more complete example.

Regarding including the whole router code in the example, it's ugly, but I can live with it as a temporary work-around.
When the issue with v0.2.x being marked as pre-release (instead of latest) is resolved, we could use https://npmcdn.org maybe

*/

/**
* @name ngLink

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample code used here for configuring routes and the ngLink is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - work in progress :-)

@petebacondarwin petebacondarwin added this to the 1.5.x milestone Feb 29, 2016
@petebacondarwin petebacondarwin force-pushed the component-router-guide branch from 1185f1a to 1a2dab0 Compare March 3, 2016 21:35
@btford
Copy link
Contributor

btford commented Mar 3, 2016

FYI I published @angular/router v0.2.0 from master– you should be able to use that now.

@petebacondarwin
Copy link
Contributor Author

Yes!

@petebacondarwin
Copy link
Contributor Author

npmcdn doesn't seem to cope with the scoped package @angular/router

@gkalpak
Copy link
Member

gkalpak commented Mar 4, 2016

I can see the files just fine (e.g. angular_1_router.js).

@petebacondarwin petebacondarwin force-pushed the component-router-guide branch from 1a2dab0 to 1b50e9b Compare March 4, 2016 11:31
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Mar 4, 2016
@petebacondarwin petebacondarwin force-pushed the component-router-guide branch from 1b50e9b to 37a25a3 Compare March 4, 2016 11:36
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Mar 4, 2016
@petebacondarwin petebacondarwin force-pushed the component-router-guide branch from 37a25a3 to f697ccc Compare March 4, 2016 13:02
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Mar 4, 2016
@petebacondarwin petebacondarwin force-pushed the component-router-guide branch from f697ccc to c1c29c3 Compare March 4, 2016 13:36
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Mar 4, 2016
@petebacondarwin petebacondarwin force-pushed the component-router-guide branch from c1c29c3 to 6a336ba Compare March 4, 2016 13:58
@petebacondarwin petebacondarwin merged commit 6a336ba into angular:master Mar 4, 2016
@petebacondarwin petebacondarwin deleted the component-router-guide branch November 24, 2016 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants