This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($http): add a note about modifying data in transformRequest #14122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -550,6 +550,15 @@ function $HttpProvider() { | |||
| * the transformed value (`function(data, headersGetter, status)`) or an array of such transformation functions, | |||
| * which allows you to `push` or `unshift` a new transformation function into the transformation chain. | |||
| * | |||
| * <div class="alert alert-warning"> | |||
| * **Note:** Angular does not make a copy of the `data` parameter before it is passed into the `transformRequest` pipeline. | |||
| * That means changes to the data are not local to the transform function (since Javascript passes objects by reference). | |||
There was a problem hiding this comment.
changes to properties on the data object are not local
Narretz
force-pushed
the
docs-http-transform
branch
from
263b434 to
0749eb4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs update
See TransformRequest in $http is changing scope #12468
Closes #12468