Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($controller): fix missing ")" #14112

Closed
wants to merge 1 commit into from
Closed

Conversation

gressus
Copy link
Contributor

@gressus gressus commented Feb 23, 2016

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs update
  • What is the current behavior? (You can also link to an open issue here)
    misspelling
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change?
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak gkalpak closed this in f70237a Feb 23, 2016
gkalpak pushed a commit that referenced this pull request Feb 23, 2016
gkalpak pushed a commit that referenced this pull request Feb 23, 2016
@gkalpak
Copy link
Member

gkalpak commented Feb 23, 2016

(Accidentally) merged and backported to v1.5.x (ad15db8) and v1.4.x (146f9c1), without noticing the CLA is not signed.
@gressus, could you please sign the CLA now ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants