This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(dateFilter): add support for STANDALONEMONTH in format (LLLL)
#14013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return function(date, formats) { | ||
| var value = date['get' + name](); | ||
| var get = uppercase(shortForm ? ('SHORT' + name) : name); | ||
| var propName = formatProp || name; | ||
| var get = uppercase(shortForm ? ('SHORT' + propName) : propName); |
There was a problem hiding this comment.
If we change this to
function dateStrGetter(name, shortForm, propPrefix) {
...
var get = uppercase((propPrefix || '') + (shortForm ? 'Short' : '') + name);
...And also change the line below to
LLLL: dateStrGetter('Month', false, 'Standalone'),Then, in the future, we can implement LLL by just doing
LLL: dateStrGetter('Month', true, 'Standalone'),[To change Standalone to a boolean is also fine]
There was a problem hiding this comment.
Good point ! (It was late 😛)
I went with the boolean (but it's easy to switch to a string prefix if needed).
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Feb 12, 2016
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13999