Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refact($componentController): don't return an object from the provide… #13977

Closed
wants to merge 1 commit into from
Closed

refact($componentController): don't return an object from the provide… #13977

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

…r constructor function

Closes #13969

@petebacondarwin petebacondarwin added this to the 1.5.1 milestone Feb 8, 2016
@Narretz
Copy link
Contributor

Narretz commented Feb 8, 2016

Should there be some sort of test for this?

@gkalpak
Copy link
Member

gkalpak commented Feb 8, 2016

It's just a refactor, it works either way (so the fact that the previous tests are passing is all we need).
(BTW, I believe the correct type in the commit message is refactor (not refact) 😃)

LGTM

@petebacondarwin
Copy link
Contributor Author

I fixed the commit message

petebacondarwin added a commit that referenced this pull request Feb 9, 2016
@petebacondarwin
refactor($componentController): don't return an object from the provi…
5497041 
…der constructor function

Closes #13969
Closes #13977
@petebacondarwin petebacondarwin deleted the issue-13969 branch November 24, 2016 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: ngMock frequency: low needs: review type: refactor
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@petebacondarwin @Narretz @gkalpak @googlebot