This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/Unit Testing): add info about promises #13975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| When testing promises, it's important to know that the resolution of promises is tied to the {@link ng.$rootScope.Scope#$digest digest cycle}. | ||
| That means a promise's `then`, `catch` and `finally` callback functions are only called after a digest has run. | ||
| In tests, you can trigger a digest by calling a scope's {@link ng.$rootScope.Scope#$apply `$apply`function}. |
There was a problem hiding this comment.
Missing whitespace before "function".
There was a problem hiding this comment.
Since many tests don't need a scope, I would say that the way to trigger a digest is by means of $rootScope.$digest(). I'm fine mentioning both was ($rootScope.$digest() and someScope.$apply()), but I would definitely mention the former.
Narretz
force-pushed
the
docs-promise-test
branch
from
922ec65 to
17ba2a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1915