Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/migration): document a BC to ngAria (d06431e) #13949

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Feb 5, 2016

No description provided.

@gkalpak gkalpak added this to the 1.5.0 milestone Feb 5, 2016
@gkalpak
Copy link
Member Author

gkalpak commented Feb 5, 2016

The BC description is a little vague (and there is no guidelines on how to modify ones code), because I am not sure myself (yet) 😃

@petebacondarwin petebacondarwin modified the milestones: 1.5.0, 1.5.1 Feb 5, 2016
@Narretz
Copy link
Contributor

Narretz commented Feb 5, 2016

The way I understand it is that this should not affect any apps, because it corrects that aria behavior? It's just technically a BC because the aria-multiline support has been removed.

@gkalpak
Copy link
Member Author

gkalpak commented Feb 5, 2016

I was confused, because this MDN article says you should put aria-multiline on <textarea>, but after further reading, I believe it's incorrect (possibly outdated).
There's a second part: Previously, the aria-multiline attribute was added to elements with a type or role of textbox (possibly custom multiline text input fields). I am not sure, if removing support for those was an oversight and if it was intentional then does it mean that the user should add it manually (or maybe that it's not possible to have a custom multilne text input (for reasons I am not aware of)).

@gkalpak
Copy link
Member Author

gkalpak commented Feb 5, 2016

After talking with @marcysutton, it is indeed not needed to add aria-multiline on <textarea elements.
Also, as she correctly pointed out, there is no way to tell if a custom input with [role="textbox"] is multiline or not, so we shouldn't add aria-multiline there either.

I've update the PR. PTAL
/cc @marcysutton

whatever reason), you'll have to add and update them manually.

Additionally, the `aria-multiline` attribute, which was previously added to elements with a `type`
or `role` on `textbox`, will not be added anymore, since there is no way `ngAria` can tell if the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of textbox?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right :)

@Narretz
Copy link
Contributor

Narretz commented Feb 8, 2016

One typo, another suggestion, otherwise LGTM

@gkalpak gkalpak closed this in 3bfeda3 Feb 8, 2016
gkalpak added a commit that referenced this pull request Feb 8, 2016
@gkalpak
Copy link
Member Author

gkalpak commented Feb 8, 2016

Thx, @Narretz !
(Backported to v1.5.x as 0cc636b.)

@gkalpak gkalpak deleted the docs-guide-migration-ngAria-BC branch February 11, 2016 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants