-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(guide/migration): document a BC to ngAria
(d06431e)
#13949
Conversation
The BC description is a little vague (and there is no guidelines on how to modify ones code), because I am not sure myself (yet) 😃 |
The way I understand it is that this should not affect any apps, because it corrects that aria behavior? It's just technically a BC because the aria-multiline support has been removed. |
I was confused, because this MDN article says you should put |
After talking with @marcysutton, it is indeed not needed to add I've update the PR. PTAL |
whatever reason), you'll have to add and update them manually. | ||
|
||
Additionally, the `aria-multiline` attribute, which was previously added to elements with a `type` | ||
or `role` on `textbox`, will not be added anymore, since there is no way `ngAria` can tell if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of textbox
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right :)
One typo, another suggestion, otherwise LGTM |
No description provided.