This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($rootScope): Set no context when calling listeners #13909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalfaso
force-pushed
the
watch-no-context
branch
3 times, most recently
from
a868e98 to
5b2f361
Compare
|
The same is true for |
When calling a $watch getter or listener, do not expose the inner workings with `this`.
lgalfaso
force-pushed
the
watch-no-context
branch
from
5b2f361 to
900de12
Compare
| function Listener() { | ||
| expect(this).toBeUndefined(); | ||
| } | ||
| if (msie < 10) return; |
There was a problem hiding this comment.
OOC, what is the problem with IE9 ?
There was a problem hiding this comment.
There is no "strict mode" in IE9, so this is window
gkalpak
pushed a commit
that referenced
this pull request
Feb 1, 2016
When calling a $watch getter or listener, do not expose the inner workings with `this`. Closes: #13909
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling a listener, do not expose the inner workings with
this.