Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($route): allow preventing a route reload #13894

Closed
wants to merge 1 commit into from
Closed

fix($route): allow preventing a route reload #13894

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jan 30, 2016

Fixes #9824

@gkalpak gkalpak force-pushed the feat-route-support-preventing-reload branch from 5c658f1 to cb65744 Compare January 30, 2016 00:35
@gkalpak gkalpak added this to the 1.5.0 milestone Jan 31, 2016
@gkalpak
Copy link
Member Author

gkalpak commented Jan 31, 2016

(I'm not sure if it's a feature or a fix actually...)

@petebacondarwin
Copy link
Contributor

LGTM

@petebacondarwin
Copy link
Contributor

Let's call it a fix!

@gkalpak gkalpak changed the title feat($route): add support for preventing a route reload fix($route): allow preventing a route reload Feb 2, 2016
@gkalpak gkalpak closed this in 2f0a50b Feb 2, 2016
@gkalpak
Copy link
Member Author

gkalpak commented Feb 2, 2016

@petebacondarwin, backport to v1.4.x (since it's a fix) ?

gkalpak added a commit that referenced this pull request Feb 2, 2016
@gkalpak
fix($route): allow preventing a route reload
4bc3031 
Fixes #9824
Closes #13894
@gkalpak
Copy link
Member Author

gkalpak commented Feb 2, 2016

Backported to v1.4.x as 4bc3031.

@gkalpak gkalpak deleted the feat-route-support-preventing-reload branch February 2, 2016 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gkalpak gkalpak

Labels
cla: yes component: ngRoute frequency: low needs: merging severity: broken expected use type: feature
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gkalpak @petebacondarwin @googlebot