This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(travis): update Chrome to 47, FF to 43, and add Safari 9 #13888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
chore-travis-safari9
branch
from
eb17997 to
9ff5901
Compare
| grunt package | ||
| if [ $JOB != "ci-checks"]; then | ||
| if [ $JOB != "unit" ]; then | ||
| # unit tests test against unminified code |
There was a problem hiding this comment.
What is the reason for this change ?
There was a problem hiding this comment.
I'm just trying some optimizations. Unit tests don't need package, and that shaves off a good minute of the unit tests. Not terribly important since e2e tests take longer anyway, but nice to have if you just want to know the unit tests pass.
There was a problem hiding this comment.
Ideally, we should test against both unminified and minified files :)
Narretz
force-pushed
the
chore-travis-safari9
branch
from
96abf42 to
b335976
Compare
Narretz
force-pushed
the
chore-travis-safari9
branch
from
b335976 to
62b5a96
Compare
Narretz
changed the title
Narretz
changed the title
Narretz
force-pushed
the
chore-travis-safari9
branch
from
62b5a96 to
527bcd0
Compare
petebacondarwin
pushed a commit
that referenced
this pull request
Feb 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.