This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): immediatelly increment $browser's outstandingRequestCount
#13869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative approach to #13862. Differences:
|
This allows protractor to more reliably detect when all outstanding requests have been completed. Fixes angular#13782 Closes angular#13862
gkalpak
force-pushed
the
fix-http-increment-request-count-immediately
branch
from
4b7b565 to
c9db640
Compare
|
I like it. |
|
The problem (as mentioned in #13782 (comment)) was that I'll update the commit message. |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Jul 15, 2016
Calling `promise.finally(...)` creates a new promise. If we don't return this promise, the user won't be able to attach an error handler to it. This commit also improves the test coverage of the increment/decrement fix. Closes angular#13869
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Jul 15, 2016
…st fails Calling `promise.finally(...)` creates a new promise. If we don't return this promise, the user won't be able to attach an error handler to it and thus won't be able to prevent a potential PUR error. This commit also improves the test coverage for the increment/decrement `outstandingRequestCount` fix. Closes angular#13869
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Jul 15, 2016
…st fails Calling `promise.finally(...)` creates a new promise. If we don't return this promise, the user won't be able to attach an error handler to it and thus won't be able to prevent a potential PUR error. This commit also improves the test coverage for the increment/decrement `outstandingRequestCount` fix. Closes angular#13869
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Jul 15, 2016
…st fails Calling `promise.finally(...)` creates a new promise. If we don't return this promise, the user won't be able to attach an error handler to it and thus won't be able to prevent a potential PUR error. This commit also improves the test coverage for the increment/decrement `outstandingRequestCount` fix. Closes angular#13869
3 tasks
petebacondarwin
pushed a commit
that referenced
this pull request
Jul 18, 2016
…st fails Calling `promise.finally(...)` creates a new promise. If we don't return this promise, the user won't be able to attach an error handler to it and thus won't be able to prevent a potential PUR error. This commit also improves the test coverage for the increment/decrement `outstandingRequestCount` fix. Closes #13869 Closes #14921
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows protractor to more reliably detect when all outstanding requests have been completed.
Fixes #13782
Closes #13862