Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/directives): improve Protractor test for bindings #13849

Closed
wants to merge 1 commit into from

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jan 26, 2016

This needs Protractor >= 1.3.0 to work.

Closes #9330

@Narretz Narretz self-assigned this Jan 26, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@gkalpak
Copy link
Member

gkalpak commented Jan 26, 2016

We are already using protractor: '^2.1.0' (even v1.3.x is on protractor: '^2.0.0'), so it shouldn't be a problem.

LGTM

@Narretz
Copy link
Contributor Author

Narretz commented Jan 26, 2016

Thanks. I as just checking the CI for completeness (e2e wouldn't run right locally)

@Narretz Narretz closed this Jan 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants