Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(compile): improve nonassign error message #13828

Closed
wants to merge 1 commit into from
Closed

feat(compile): improve nonassign error message #13828

wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • Improve error message to mention attribute the expression errored on

This implements #13827.

@wesleycho wesleycho force-pushed the feat/nonassign-message branch from f5db3db to 6021188 Compare January 22, 2016 21:00
@gkalpak
Copy link
Member

gkalpak commented Jan 23, 2016

LGTM. Please, add Fixes #... at the end of the comit message, so the related issues will be automatically closed.

(I also think it's preferrable to have such change as docs, rather than feat.)

@gkalpak gkalpak added this to the 1.5.x - migration-facilitation milestone Jan 23, 2016
@gkalpak gkalpak self-assigned this Jan 23, 2016
@wesleycho
docs(compile): improve nonassign error message
dc75d59 
- Improve error message to mention attribute the expression errored on

Fixes angular#13827
@wesleycho wesleycho force-pushed the feat/nonassign-message branch from 6021188 to dc75d59 Compare January 23, 2016 14:21
@wesleycho
Copy link
Contributor Author

Done

@Narretz Narretz closed this in 4ff9c02 Jan 24, 2016
Narretz pushed a commit that referenced this pull request Jan 24, 2016
@wesleycho @Narretz
docs($compile): improve nonassign error message
fdbd92f 
- Improve error message to mention attribute the expression errored on

Fixes #13827

Closes #13828
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gkalpak gkalpak

Labels
cla: yes component: $compile severity: confusing type: docs
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@wesleycho @gkalpak @googlebot