Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(component): log a warning for unsupported options in CDO #13802

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jan 19, 2016

No description provided.

@petebacondarwin
Copy link
Contributor

This is going to add quite a bit to the size of angular.min.js. Perhaps we can find a way to make the message shorter - perhaps just provide a URL to some docs?

@gkalpak
Copy link
Member Author

gkalpak commented Jan 19, 2016

Hm...good point about the file size. The problem with pointing to a specific URL is that we'd need to produce it based on the Angular version used (as the docs might change from version to version).

How about dropping "ALIASED" (moving them into "UNSUPPORTED") and have on message like:

'NOTICE: Unsupported options in component "' + componentName + '":\n  ' + unsupportedOpts.join(', ')

@petebacondarwin
Copy link
Contributor

Actually, I thought about this a bit more. Really this is the kind of thing for which we created ngHint. I think we should either add a plugin for that or just do nothing. People will soon realise that their directives are not working as planned. @Narretz new component guide has a nice table that makes it quite clear what options are in and what are out

@gkalpak
Copy link
Member Author

gkalpak commented Jan 20, 2016

Also makes sense. Closing...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants