This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor: move component helper to the $compileProvider #13692
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
refact-component
branch
from
69c7187 to
ae5b22a
Compare
The Module.component() now delegates to $compileProvider.component(). This has the following benefits: - when using only the loader, we are not accessing out of scope variables / functions - components can be registered via $compileProvider - docs are a bit easier to find
Narretz
force-pushed
the
refact-component
branch
from
ae5b22a to
50a9a0c
Compare
| }); | ||
| }); | ||
|
|
||
| it('should register a directive via $compileProvider.component()', function() { |
There was a problem hiding this comment.
this test is also new
|
A couple of minor nitpicks, but LGTM otherwise. This will (obviously) affect the fix for angular/batarang#275. |
|
LGTM - merging with tweaks suggested by @gkalpak and some minor docs changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Module.component() now delegates to $compileProvider.component().
This has the following benefits:
/cc @petebacondarwin @shahata