Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($interpolateProvider): describe your change... #13608

Closed
wants to merge 1 commit into from

Conversation

sakkeerhussain
Copy link

App name was different in two parts in example code.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -44,7 +44,7 @@ $interpolateMinErr.interr = function(text, err) {
this.label = "This binding is brought you by // interpolation symbols.";
});
</script>
<div ng-app="App" ng-controller="DemoController as demo">
<div ng-app="customInterpolationApp" ng-controller="DemoController as demo">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the protractor test below didn't catch this. Not very reassuring... :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I signed it!

Thanks,
Sakkeer Hussain

On 22 December 2015 at 16:26, Georgios Kalpakas [email protected]
wrote:

In src/ng/interpolate.js
#13608 (comment):

@@ -44,7 +44,7 @@ $interpolateMinErr.interr = function(text, err) {
this.label = "This binding is brought you by // interpolation symbols.";
});
</script>
-


+

I wonder why the protractor test below didn't catch this. Not very
reassuring... :)


Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/13608/files#r48242715.

Narretz added a commit to Narretz/angular.js that referenced this pull request Dec 31, 2015
The example processor is adding the module attr in the example tag as
the ng-app attr on the body.

Closes angular#13608
@Narretz Narretz self-assigned this Dec 31, 2015
@Narretz
Copy link
Contributor

Narretz commented Dec 31, 2015

The example processor is adding the module defined by <example module="customInterpolationApp"> as the ng-app on the body tag. So the right fix is to remove the ng-app from the index.html

@Narretz Narretz closed this in b8fb0c4 Dec 31, 2015
Narretz added a commit that referenced this pull request Dec 31, 2015
The example processor is adding the module attr in the example tag as
the ng-app attr on the body.

Closes #13608
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants