Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(GruntFile): check angularFiles (update) #13569

Closed
wants to merge 6 commits into from

Conversation

petebacondarwin
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@petebacondarwin
Copy link
Contributor Author

@matsko - can you take a look at these changes to your PR?

});

if (errorsDetected) {
throw new Error("Not all files were properly detected in the local file structure.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is not 100% accurate (as the errors might be due to files in the local file structure not being used).

@gkalpak
Copy link
Member

gkalpak commented Dec 17, 2015

LGTM with a minor comment (despite the inconsistent use of '/" 😛)

@matsko
Copy link
Contributor

matsko commented Dec 17, 2015

@petebacondarwin LGTM. Please upload as is. I will fix the error message that @gkalpak pointed out to something better in a follow-up commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants