-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(GruntFile): check angularFiles (update) #13569
Conversation
This prevents errors when checking `validate-angular-files`
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@matsko - can you take a look at these changes to your PR? |
}); | ||
|
||
if (errorsDetected) { | ||
throw new Error("Not all files were properly detected in the local file structure."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message is not 100% accurate (as the errors might be due to files in the local file structure not being used).
LGTM with a minor comment (despite the inconsistent use of |
@petebacondarwin LGTM. Please upload as is. I will fix the error message that @gkalpak pointed out to something better in a follow-up commit. |
No description provided.