chore(jenkins): run Jenkins builds on Node 4 (via nvm) #13568
Conversation
petebacondarwin
force-pushed
the
jenkins-hacks
branch
from
bf266b6 to
ae14419
Compare
| #!/bin/bash | ||
|
|
||
| # Install nvm for this shell | ||
| source ~/.nvm/nvm.sh |
There was a problem hiding this comment.
Does jenkins provide this (i.e. where does it come from)?
There was a problem hiding this comment.
It is manually installed on the server.
There was a problem hiding this comment.
Could we print the nvm/Node/npm versions used? Could be useful for debugging.
There was a problem hiding this comment.
I think that it does do that automatically...
+ scripts/jenkins/set-node-version.sh
v4.2.3 is already installed.
Now using node v4.2.3 (npm v2.14.7)
| source ~/.nvm/nvm.sh | ||
|
|
||
| # Use node.js at 4.2.x | ||
| nvm install 4.2 |
There was a problem hiding this comment.
Is nvm install ... sufficient or do we also need nvm use ... ?
There was a problem hiding this comment.
nvm install is sufficient.
There was a problem hiding this comment.
4 would be enough, the latest 4.x.y release is an LTS, it so happens it's 4.2.y in fact.
There was a problem hiding this comment.
From the node.js docs:
Minors: Minors are the addition and refinements of APIs or subsystems. They do not generally change APIs or introduce backwards compatible breaking changes, except where unavoidable. These are mostly completely additive releases.
I think it is safer to stick with a fixed minor release for automatic updates
There was a problem hiding this comment.
OK. It doesn't matter here anyway as there will be no Node.js 4.3.
There was a problem hiding this comment.
No description provided.