Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(linky): do not throw on non-string values #13551

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Dec 15, 2015

Fixes #13547

@gkalpak
Copy link
Member Author

gkalpak commented Dec 15, 2015

I am not sure we want to fix this actually. We've been moving in the opposite direction with other filters lately (e.g. filterFilter and orderBy throwing if not passed an array).

In any case, I think it's better to either explicitly throw (as with other filters) or return the input unchanged, if it's not a string.

@lgalfaso
Copy link
Contributor

I am leaning towards not making this change, but I am fine if enough people wants this change

@gkalpak
Copy link
Member Author

gkalpak commented Dec 16, 2015

@lgalfaso
Copy link
Contributor

@gkalpak with the right BC notice, yes, I think that that way is much better

@petebacondarwin
Copy link
Contributor

OK @gkalpak - let's go with throwing in non-sensical cases...

@gkalpak
Copy link
Member Author

gkalpak commented Jan 6, 2016

Closing in favor of #13693.
@lgalfaso, @petebacondarwin, feel free to take a look at #13693 😄

@gkalpak gkalpak closed this Jan 6, 2016
@gkalpak gkalpak deleted the fix-linky-handle-non-string-values branch January 8, 2016 09:31
@gkalpak gkalpak restored the fix-linky-handle-non-string-values branch January 8, 2016 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants