Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update animateCss.js to not remove events from elements #13502

Closed
wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

animateCss currently removes all events from and element during close(). We should check if any animationend events have occured by checking the length of the events array, rather than its truthiness.

animateCss currently removes all events from and element during close().  We should check if any animationend events have occured by checking the length of the events array, rather than its truthiness.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Dec 11, 2015

@josephperrott, thx for submitting this. Before we can merge it though, there needs to be a test that shows that the issue is fixed and prevent future regressions (plus what @googlebot said regarding the CLA).

@Narretz
Copy link
Contributor

Narretz commented Dec 11, 2015

@josephperrott How did you find this bug? The code only removes all events if the animation hasn't started yet. In all other cases it works.

@Narretz
Copy link
Contributor

Narretz commented Dec 11, 2015

And again with a test: #13514

@Narretz Narretz closed this Dec 11, 2015
@josephperrott josephperrott deleted the patch-1 branch December 11, 2015 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants