This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animateCss): remove animation end event listeners on close #13461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
fix-animate-endevent-10387
branch
from
7355a96 to
7b50582
Compare
|
Now it's good enough! |
Narretz
force-pushed
the
fix-animate-endevent-10387
branch
from
7b50582 to
ae932a4
Compare
Narretz
force-pushed
the
fix-animate-endevent-10387
branch
from
ae932a4 to
970e71b
Compare
|
This looks really good. Please fix up the PR with the spy changes and let's get this green and merge it in. |
|
Thanks for the review. The changes simplfy the code quite a bit! I've also added an expect to see if the on/off calls match transition/animation-end. That way I caught a bug in test - the closing test didn't actually test for animationend. I will squash the commits if it LGTY. |
Narretz
force-pushed
the
fix-animate-endevent-10387
branch
from
4dada5c to
9c0fbe8
Compare
Previously the transition/animation end events were not removed when the animation was closed. This normally didn't matter, because the close function knows the animations are closed and won't do work twice. However, the listeners themselves do computation that could fail when the event was missing some data, for example when the event was triggered instead of natural. Closes angular#10387
Narretz
force-pushed
the
fix-animate-endevent-10387
branch
from
9c0fbe8 to
20604e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the transition/animation end events were not removed when the
animation was closed. This normally didn't matter, because
the close function knows the animation are closed and won't do work
twice.
However, the listeners themselves do computation that could fail when
the event was missing some data, for example when the event was
triggered instead of natural.
Closes #10387