This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(booleanAttrsSpec): add unit test for IE11 URL parsing failure #13458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andypatterson
force-pushed
the
add-ie11-percent-url-test
branch
from
00e7da2 to
c148473
Compare
IE11/10/Edge fail when setting a href to a URL containing a % that isn't a valid escape sequence Reference: angular#13388
andypatterson
force-pushed
the
add-ie11-percent-url-test
branch
from
c148473 to
aea0ef3
Compare
|
If the point of this is to highlight a bug in IE then we should make that clear in the code as well as the commit and include a link to the issue. Otherwise when this starts to fail we will wonder why it was ever there. |
|
Otherwise LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11/10/Edge fail when setting a href to a URL containing a % that isn't a valid escape sequence
Reference: #13388