Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fixed the headings for Changes to your code table #13456

Closed
wants to merge 1 commit into from

Conversation

eltronix
Copy link

@eltronix eltronix commented Dec 7, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

gkalpak added a commit to gkalpak/angular.js that referenced this pull request Dec 7, 2015
@gkalpak gkalpak closed this in e9aba90 Dec 7, 2015
gkalpak added a commit that referenced this pull request Dec 7, 2015
@gkalpak
Copy link
Member

gkalpak commented Dec 7, 2015

The resulting HTML was not valid due to multiple thead elements (according to MDN at least - browsers seem to handle the resulting DOM fine).

I fixed this in #13459 (which also takes care of vertical spacing and header borders), but thx @eltronix for taking the time to submit the PR (and for bringing this to our attention).

@eltronix
Copy link
Author

eltronix commented Dec 7, 2015

Your welcome, thanks for responding.
On 7 Dec 2015 8:59 pm, "Georgios Kalpakas" [email protected] wrote:

The resulting HTML was not valid due to multiple thead elements (according
to MDN https://developer.mozilla.org/en-US/docs/Web/HTML/Element/table
at least - browsers seem to handle the resulting DOM fine).

I fixed this in #13459 #13459
(which also takes care of vertical spacing and header borders), but thx
@eltronix https://github.com/eltronix for taking the time to submit the
PR (and for bringing it to our attention).


Reply to this email directly or view it on GitHub
#13456 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants