This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): allow transclude maps to use normalized camelCase element names #13455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * used to match the HTML to the slot. Only element names are supported for matching. If the element selector | ||
| * is prefixed with a `?` then that slot is optional. | ||
| * This object is a map where the keys are the name of the slot to fill and the value is an element selector | ||
| * used to match the HTML to the slot. The element selector can be in normalized camelCase form and will match |
There was a problem hiding this comment.
We could link to the directive guide/normalization here
|
I wonder what happens if we have an "svg directive"? Because some svg elements are camelCased: https://developer.mozilla.org/docs/Web/SVG/Element |
|
Another thing: is it worth mentioning that slot transclusion always transcludes the element and not just its contents? |
Yes - I will add that |
petebacondarwin
force-pushed
the
multi-slot-normalize
branch
from
60dad74 to
96dd940
Compare
|
We just need to make sure this BC doesn't make it into the migration docs. Can you amend the commit message to say this only affects 1.5.0 betas? |
|
Also, the commit message doesn't reflect what the commit actually does. Otherwise, LGTM |
Closes angular#13439 BREAKING CHANGE: The keys and values for the `transclude` map of the directive definition have been swapped around to be more consistent with the other maps, such as `scope` and `bindToController`. Now the key is the slot name and the value is an element selector.
petebacondarwin
force-pushed
the
multi-slot-normalize
branch
from
96dd940 to
a5aadcd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to do this was removed at c3a2691#diff-a732922b631efed1b9f33a24082ae0dbL1881
On second thoughts we should support both camelCase normalized and exact match elements.
Closes #13439