This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($compile): move setup/get controller methods out of the compile node closure #13427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
11618-setupget-controllers
branch
2 times, most recently
from
6ed81a3 to
587cdff
Compare
|
I've split this into two commits so the second only moves the functions and does not change the function bodies. |
| var controllerInstance = $controller(controller, locals, true, directive.controllerAs); | ||
|
|
||
| // For directives with element transclusion the element is a comment. | ||
| // In this case jQuery .data will not attach any data. |
There was a problem hiding this comment.
This sounds like jqLite will attach the data (which is won't afaict).
jbedard
force-pushed
the
11618-setupget-controllers
branch
from
587cdff to
78c75fc
Compare
|
Rebased and fixed the comment |
Narretz
pushed a commit
that referenced
this pull request
Feb 29, 2016
…ile node closure Closes #13427
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves two methods out of the per-element compile closure.
getControllershas no changessetupControllersrequired thenewIsolateScopeDirectiveparam and the use ofhasElementTranscludeDirectivewas removed (.data on a comment is a noop). This can be a little simpler after something such as #13421