This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($compile): move check for interpolation of on-event attributes to compile time #13267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to compile time BREAKING CHANGE: Previously the nodomevents would be thrown at link time for any interpolation on* event attributes. Now this will be throw at compile time similar to the selmulti error.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Previously the nodomevents would be thrown at link time for any interpolation on* event attributes. Now this will be throw at compile time similar to the selmulti error.
The breaking change should be rare, but is probably worth mentioning. This makes the two interpolation errors consistent and avoids checking the same thing per link (which previously would log the same error per link).
The test changes are not necessary but do make them stricter and more like the selmulti error tests.