Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Feat linky 12558 #13061

Merged
merged 2 commits into from
Oct 9, 2015
Merged

Feat linky 12558 #13061

merged 2 commits into from
Oct 9, 2015

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Oct 9, 2015

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

<th>Filter</th>
<th>Source</th>
<th>Rendered</th>
</thead>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

th are encouraged to use under thead without tr? I understand all browsers work either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what do you mean? Should I use tr instead of thead?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browsers generated both, if you miss one of them. But I am not html spec expert.
Just wondering why it has to be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right that you shouldn't use <thead> without <tr>, even though browser generate the <tr>. What I really wanted was to have the <th> because that improves the formatting.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I really wanted was to have the because that improves the formatting.

I see, you're right.

Narretz pushed a commit to Narretz/angular.js that referenced this pull request Oct 9, 2015
Optional extra attributes may be defined either as:
- a map of attributes and values
- a function that takes the url as a parameter and returns a map

Closes angular#12558
Closes angular#13061
Narretz pushed a commit to Narretz/angular.js that referenced this pull request Oct 9, 2015
Optional extra attributes may be defined either as:
- a map of attributes and values
- a function that takes the url as a parameter and returns a map

Closes angular#12558
Closes angular#13061
stianjensen and others added 2 commits October 9, 2015 15:10
Optional extra attributes may be defined either as:
- a map of attributes and values
- a function that takes the url as a parameter and returns a map

Closes angular#12558
Closes angular#13061
@Narretz Narretz merged commit 40c974a into angular:master Oct 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants