-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
<th>Filter</th> | ||
<th>Source</th> | ||
<th>Rendered</th> | ||
</thead> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
th
are encouraged to use under thead
without tr
? I understand all browsers work either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what do you mean? Should I use tr
instead of thead
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browsers generated both, if you miss one of them. But I am not html spec expert.
Just wondering why it has to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right that you shouldn't use <thead>
without <tr>
, even though browser generate the <tr>
. What I really wanted was to have the <th>
because that improves the formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I really wanted was to have the because that improves the formatting.
I see, you're right.
60545f1
to
86aaa4c
Compare
Optional extra attributes may be defined either as: - a map of attributes and values - a function that takes the url as a parameter and returns a map Closes angular#12558 Closes angular#13061
666a20f
to
9f57e5b
Compare
Optional extra attributes may be defined either as: - a map of attributes and values - a function that takes the url as a parameter and returns a map Closes angular#12558 Closes angular#13061
Optional extra attributes may be defined either as: - a map of attributes and values - a function that takes the url as a parameter and returns a map Closes angular#12558 Closes angular#13061
9f57e5b
to
40c974a
Compare
No description provided.